Comments on: ‘Copy’ UI action for Change requests (Part 2!)

By: Mark Stanger

Mark Stanger — Wed, 08 Feb 2012 18:51:09 +0000

Hey Paul,

I assume you’re talking about ‘task_ci’, not ‘task_group. If so, the ‘current.sys_id’ line refers to the new change record being created. The sys_id of the ‘task_ci’ record will be automatically generated so you shouldn’t need to worry about setting it.

Thanks for the feedback on SNCGuru! Let me know if you’ve got any suggestions.

By: Paul Davidson

Paul Davidson — Wed, 08 Feb 2012 14:14:55 +0000

Hi Mark,

I was able to follow your logic to create additional copy modules for the other “Related Lists” that we use on our Change tickets. To ensure appropriate logging, I was careful to manually set all of the table columns like sys_created_by, sys_created_on, sys_updated_by, sys_updated_on, etc.

In your copyCI() script you set the ‘task_group’ table’s “task” column to the current.sys_id. I see that the task column is a reference field, so I’m assuming it is referencing the newly created Change ticket’s sys_id. I guess I’m asking if the current object at this point is the Change ticket or the ‘task_group’ record?

What about the sys_id column within the ‘task_group’ table? Are newly created records getting the same sys_id from the existing record that it is copying from? Do I need to manually set the sys_id within ‘task_group’ table?, or is it getting a unique value at Insert?

It is nice that people like you share your effort gained Knowledge with the rest of us, so we can have a starting point for learning ourselves.

Thanks again!
-Paul

By: Mark Stanger

Mark Stanger — Wed, 04 Jan 2012 14:30:20 +0000

I’m glad it worked! It was great to meet you too.

By: Scott Hetzel

Scott Hetzel — Wed, 04 Jan 2012 14:17:22 +0000

Mark.. That worked, perfect.

Thanks for the help! (also…nice meeting you and Jacob in San Diego in early December)

By: Mark Stanger

Mark Stanger — Wed, 04 Jan 2012 00:23:43 +0000

Good catch Scott. The numbering is controlled by the ‘getNextObjNumberPadded’ line. The issue in this case is that we’re dealing with the change request context and the change tasks…and that function doesn’t understand both of them. The only way I know of to get around this is to use a Packages call in place of the standard call. I’ve updated the scripts above with this fix. Let me know how it works for you.

newTask.number = Packages.com.glide.db.NumberManager.getNumber('change_task');

By: Scott Hetzel

Scott Hetzel — Tue, 03 Jan 2012 22:48:07 +0000

Mark,

I’m using the first script above and when copying change_tasks it gives me the number prefix defined for the change_request table. I get RFC1234 instead of the desired CTASK1234.

Thanks,
Scott

By: Mark Stanger

Mark Stanger — Thu, 06 Oct 2011 20:31:59 +0000

You can override any value on the change request you generate by adding a new ‘newChange’ line in the section of code that copies the change request. For approval you could do something like this…

newChange.approval = 'not_requested';

If you don’t want to copy the associated CIs then just comment out this line in the code…

copyCI(chgID);

By: Manny Tsoplakis

Manny Tsoplakis — Thu, 06 Oct 2011 13:27:09 +0000

Hi, this works pretty well but when i implement this, the change is copying over with approved as the “approval”. It is also copying over the journal entries in the activity list. Also, is there a way to copy the existing record without adding the CI? thanks

By: Jim Coyne

Jim Coyne — Sun, 20 Mar 2011 10:36:13 +0000

Thanks for the article, came in handy with a client. I was a little confused at first when I saw you were making changes to the “newChange” variable but then used “current.insert();” to make the insert of the record. I then realized that “var newChange = current;” actually keeps a live connection between both objects, so any change to one affects the other. I’m no JavaScript expert, but I guess it may not even be worth creating the “newChange” variable at all and just use “current”.

By: Mark Stanger

Mark Stanger — Wed, 26 Jan 2011 16:17:45 +0000

Hey, thanks so much for the feedback. I’ve updated the scripts above to include this fix. Good catch!

By: Peter Oneppo

Peter Oneppo — Wed, 26 Jan 2011 15:52:38 +0000

Mark,

This is great. We just implemented it for one of our clients, but we ran into a small snag. We were getting duplicate numbers for the copied records. I think the problem is related to the fact that the customer has the check box for “Assign a task number only upon insert (prevents unused numbers)” under “System Properties -> System” selected.

We solved this problem by adding one line of code to the above script:

var newChange = current;

newChange.number = getNextObjNumberPadded(); //new line to fix duplicate number problem

newChange.requested_by_date = ‘NULL’;

Thanks!

Peter